GH-50103: [C++] Missing iosfwd include in cpp/src/arrow/util/string_util.h#50101
Conversation
std::unique_ptr<std::ostringstream> sstream_; require sstream. Bug raised while building with gcc-17 https://bugs.gentoo.org/976604
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
atupone
changed the title
|
|
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks! Seems related to this commit on GCC:
gcc-mirror/gcc@396ad1175450
cc @pitrou
github-actions
Bot
added
awaiting merge
|
|
||
| #include <memory> | ||
| #include <ostream> | ||
| #include <sstream> |
There was a problem hiding this comment.
Can we please include <iosfwd> instead?
There was a problem hiding this comment.
Done. I didn't squash. Should I ?
pitrou
changed the title
|
Thank you @atupone ! This is now merged. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 90a4497. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them. |
3 participants
std::ostringstreamrequires corresponding header inclusion.Bug raised while building with gcc-17
https://bugs.gentoo.org/976604